[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 #13039

AlahmadiQ8 · 2021-02-18T16:39:21Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-02-18T16:39:24Z

Hi, @AlahmadiQ8 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2021-02-18T16:39:25Z

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2019-10-01/consumption.json <---> new: stable/2019-10-01/consumption.json

Rule	Message
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L2155:9 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L2155:9

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- consumption/resource-manager/readme.md tag:package-2019-10
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- consumption/resource-manager/readme.md tag:package-2019-10

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️[Staging] SDK Track2 Validation: 52 Warnings warning [Detail]

Only 10 items are listed, please refer to log for more details.

The following tags are being changed in this PR

consumption/resource-manager/readme.md#package-2019-10

Rule	Message
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'MeterDetails' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'UsageDetailsListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'LegacyUsageDetailProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'ModernUsageDetailProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'ReservationSummariesListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'ReservationSummaryProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'ReservationDetailsListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'ReservationDetailProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'ReservationRecommendationDetailsProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'ReservationRecommendationDetailsCalculatedSavingsProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️❌[Staging] SpellCheck: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` HowToFix	Unknown word (Identifer), please fix the error or add words to ./custom-words.txt path: Microsoft.Consumption/stable/2019-10-01/consumption.json#L2352:27

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-02-18T16:39:25Z

Swagger Generation Artifacts

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 411a565. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-02-25 02:12:28 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-consumption"
cmderr	[generate.py] 2021-02-25 02:12:28 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-02-25 02:12:28 INFO autorest --version=3.0.6369 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/consumption/azure-resourcemanager-consumption --java.namespace=com.azure.resourcemanager.consumption   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
cmderr	[generate.py] 2021-02-25 02:13:17 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-02-25 02:13:17 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-02-25 02:13:17 INFO [POM][Skip] pom already has module azure-resourcemanager-consumption
cmderr	[generate.py] 2021-02-25 02:13:17 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-02-25 02:13:17 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-02-25 02:13:17 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-consumption [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-02-25 02:16:26 DEBUG Got artifact_id: azure-resourcemanager-consumption
cmderr	[Inst] 2021-02-25 02:16:26 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-02-25 02:16:26 DEBUG Got artifact: azure-resourcemanager-consumption-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-25 02:16:26 DEBUG Match jar package: azure-resourcemanager-consumption-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-25 02:16:26 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13039/azure-sdk-for-java/azure-resourcemanager-consumption/azure-resourcemanager-consumption-1.0.0-beta.1.jar\" -o azure-resourcemanager-consumption-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-consumption -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-consumption-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 411a565. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-consumption [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model Marketplace has a new parameter etag
info	[Changelog]   - Model Notification has a new parameter threshold_type
info	[Changelog]   - Model Operation has a new parameter id
info	[Changelog]   - Model TagsResult has a new parameter next_link
info	[Changelog]   - Model TagsResult has a new parameter previous_link
info	[Changelog]   - Model Balance has a new parameter etag
info	[Changelog]   - Model Tag has a new parameter value
info	[Changelog]   - Model PriceSheetResult has a new parameter etag
info	[Changelog]   - Model Resource has a new parameter etag
info	[Changelog]   - Model ReservationSummary has a new parameter etag
info	[Changelog]   - Model ReservationSummary has a new parameter total_reserved_quantity
info	[Changelog]   - Model ReservationSummary has a new parameter purchased_quantity
info	[Changelog]   - Model ReservationSummary has a new parameter utilized_percentage
info	[Changelog]   - Model ReservationSummary has a new parameter kind
info	[Changelog]   - Model ReservationSummary has a new parameter remaining_quantity
info	[Changelog]   - Model ReservationSummary has a new parameter used_quantity
info	[Changelog]   - Model Budget has a new parameter filter
info	[Changelog]   - Model ReservationDetail has a new parameter kind
info	[Changelog]   - Model ReservationDetail has a new parameter instance_flexibility_ratio
info	[Changelog]   - Model ReservationDetail has a new parameter instance_flexibility_group
info	[Changelog]   - Model ReservationDetail has a new parameter etag
info	[Changelog]   - Model ManagementGroupAggregatedCostResult has a new parameter etag
info	[Changelog]   - Model Forecast has a new parameter etag
info	[Changelog]   - Added operation ReservationRecommendationsOperations.list
info	[Changelog]   - Added operation ReservationsDetailsOperations.list
info	[Changelog]   - Added operation ReservationsSummariesOperations.list
info	[Changelog]   - Added operation ChargesOperations.list
info	[Changelog]   - Added operation group LotsOperations
info	[Changelog]   - Added operation group ReservationTransactionsOperations
info	[Changelog]   - Added operation group CreditsOperations
info	[Changelog]   - Added operation group EventsOperations
info	[Changelog]   - Added operation group ReservationRecommendationDetailsOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model Budget no longer has parameter filters
info	[Changelog]   - Model ChargeSummary has a new signature
info	[Changelog]   - Model UsageDetail has a new signature
info	[Changelog]   - Model ReservationRecommendation has a new signature
info	[Changelog]   - Removed operation UsageDetailsOperations.download
info	[Changelog]   - Removed operation ChargesOperations.list_by_scope

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 411a565. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Consumption [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.Consumption.3.0.2.nupkg
- Microsoft.Azure.Management.Consumption.3.0.2.snupkg

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 411a565. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/[email protected] --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/consumption/resource-manager/readme.md

️✔️consumption [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager]  WARN [email protected] No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 411a565. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/consumption/resource-manager/readme.md

️✔️@azure/arm-consumption [View full logs] [Release SDK Changes]

azure-arm-consumption-6.3.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/consumptionManagementClient.js → ./dist/arm-consumption.js...
cmderr	[npmPack] created ./dist/arm-consumption.js in 666ms

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 411a565. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️consumption/mgmt/2019-10-01/consumption [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 11 items here, please refer to log for details.

info	[Changelog] - New field `Value` in struct `Tag`
info	[Changelog] - New field `ID` in struct `Operation`
info	[Changelog] - New field `Etag` in struct `ReservationSummary`
info	[Changelog] - New field `PayGPrice` in struct `ModernUsageDetailProperties`
info	[Changelog] - New field `Etag` in struct `ReservationDetail`
info	[Changelog] - New field `Etag` in struct `ReservationRecommendation`
info	[Changelog] - New field `Etag` in struct `LegacyChargeSummary`
info	[Changelog] - New field `Etag` in struct `Balance`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 31 additive change(s).
info	[Changelog]

️✔️consumption/mgmt/2019-01-01/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-10-01/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-08-31/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-06-30/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-05-31/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-03-31/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-01-31/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2017-11-30/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/consumption/mgmt/2017-12-30-preview/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/consumption/mgmt/2017-04-24-preview/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 411a565. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-consumption [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model ReservationDetail has a new parameter etag
info	[Changelog]   - Model ManagementGroupAggregatedCostResult has a new parameter etag
info	[Changelog]   - Model Resource has a new parameter etag
info	[Changelog]   - Model CreditSummary has a new parameter etag
info	[Changelog]   - Model ReservationRecommendation has a new parameter etag
info	[Changelog]   - Model LegacyChargeSummary has a new parameter etag
info	[Changelog]   - Model Balance has a new parameter etag
info	[Changelog]   - Model Forecast has a new parameter etag
info	[Changelog]   - Model Operation has a new parameter id
info	[Changelog]   - Model ReservationRecommendationDetailsModel has a new parameter etag
info	[Changelog]   - Model ChargeSummary has a new parameter etag
info	[Changelog]   - Model EventSummary has a new parameter etag
info	[Changelog]   - Model PriceSheetResult has a new parameter etag
info	[Changelog]   - Model ModernChargeSummary has a new parameter etag
info	[Changelog]   - Model ModernUsageDetail has a new parameter pay_g_price
info	[Changelog]   - Model ModernUsageDetail has a new parameter etag
info	[Changelog]   - Model LegacyReservationRecommendation has a new parameter etag
info	[Changelog]   - Model LegacyReservationRecommendation has a new parameter resource_type
info	[Changelog]   - Model LegacyUsageDetail has a new parameter etag
info	[Changelog]   - Model ModernReservationRecommendation has a new parameter etag
info	[Changelog]   - Model Marketplace has a new parameter etag
info	[Changelog]   - Model LotSummary has a new parameter etag
info	[Changelog]   - Model ReservationSummary has a new parameter etag
info	[Changelog]   - Model TagsResult has a new parameter next_link
info	[Changelog]   - Model TagsResult has a new parameter previous_link
info	[Changelog]   - Model UsageDetail has a new parameter etag
info	[Changelog]   - Model Tag has a new parameter value

️🔄[Staging] ApiDocPreview inProgress [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-02-18T16:41:26Z

Hi @AlahmadiQ8, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

openapi-workflow-bot · 2021-02-18T16:42:09Z

Hi @AlahmadiQ8, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

openapi-workflow-bot · 2021-02-18T16:44:02Z

In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki Window to Fix Broken for more details.

…Properties

AlahmadiQ8 · 2021-02-19T03:00:53Z

@weidongxu-microsoft This PR fixes the S360 errors for the Usage Details List endpoint owned by the Azure Cost Management team.

https://msazure.visualstudio.com/Swagger%20KPIs/_workitems/edit/8187825
https://vnext.s360.msftcloudes.com/blades/unifiedplatform?blade=KPI:cf751b97-2c95-420f-baa8-9a16e8643a5b~SLA:2~AssignedTo:All~Forums:All~_loc:UnifiedPlatform&def=&peopleBasedNodes=laagrawa_team;raphaelc_team;ashwinsa_team;mawadwan_team;adwise_team;pamog_team;shbharadwaj_team&tile=S360_ServiceId:80383977-026e-47cb-8a1b-7e7c3eff7350~_loc:__key__UnifiedPlatform__cf751b97-2c95-420f-baa8-9a16e8643a5b

weidongxu-microsoft · 2021-02-19T03:07:02Z

...cation/consumption/resource-manager/Microsoft.Consumption/stable/2019-10-01/consumption.json

@@ -152,6 +152,9 @@
              "$ref": "#/definitions/UsageDetailsListResult"
            }
          },
+          "503": {


I don't think 503 need to be added separately. It should be same as default below.

If you add 503 here, it actually means 503 is now the expected return code, and client should be good with it and proceed.

The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: #12777 #12555 #13039 #13097 #12822 #13280 #12942 #13248 #13378 This PR is to add those corrections to 2019-11-01 version

Adding fixes made in 2019-10-01 to 2019-11-01 (Azure#13414) The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: Azure/azure-rest-api-specs#12777 Azure/azure-rest-api-specs#12555 Azure/azure-rest-api-specs#13039 Azure/azure-rest-api-specs#13097 Azure/azure-rest-api-specs#12822 Azure/azure-rest-api-specs#13280 Azure/azure-rest-api-specs#12942 Azure/azure-rest-api-specs#13248 Azure/azure-rest-api-specs#13378 This PR is to add those corrections to 2019-11-01 version

Adding fixes made in 2019-10-01 to 2019-11-01 (#13414) The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: Azure/azure-rest-api-specs#12777 Azure/azure-rest-api-specs#12555 Azure/azure-rest-api-specs#13039 Azure/azure-rest-api-specs#13097 Azure/azure-rest-api-specs#12822 Azure/azure-rest-api-specs#13280 Azure/azure-rest-api-specs#12942 Azure/azure-rest-api-specs#13248 Azure/azure-rest-api-specs#13378 This PR is to add those corrections to 2019-11-01 version

Adding fixes made in 2019-10-01 to 2019-11-01 (Azure#13414) The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: Azure/azure-rest-api-specs#12777 Azure/azure-rest-api-specs#12555 Azure/azure-rest-api-specs#13039 Azure/azure-rest-api-specs#13097 Azure/azure-rest-api-specs#12822 Azure/azure-rest-api-specs#13280 Azure/azure-rest-api-specs#12942 Azure/azure-rest-api-specs#13248 Azure/azure-rest-api-specs#13378 This PR is to add those corrections to 2019-11-01 version

Adding fixes made in 2019-10-01 to 2019-11-01 (#13414) The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: Azure/azure-rest-api-specs#12777 Azure/azure-rest-api-specs#12555 Azure/azure-rest-api-specs#13039 Azure/azure-rest-api-specs#13097 Azure/azure-rest-api-specs#12822 Azure/azure-rest-api-specs#13280 Azure/azure-rest-api-specs#12942 Azure/azure-rest-api-specs#13248 Azure/azure-rest-api-specs#13378 This PR is to add those corrections to 2019-11-01 version

The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: Azure#12777 Azure#12555 Azure#13039 Azure#13097 Azure#12822 Azure#13280 Azure#12942 Azure#13248 Azure#13378 This PR is to add those corrections to 2019-11-01 version

…on stable/2019-10-01 (Azure#13039) * Fix validation errors for UsageDetails_List * fix validations for UsageDetails_List invalid format * update description for meterId Property inLegacyUsageDetailProperties * add examples for 503 response for Microsoft.Consumption usage details * fix spelling for productIdentifier description * fix spell check in productIdentifier description in ModernUsageDetailProperties * reverting bad fixes for swagger validations * remove 503 as a separate status * fix typos and add uuid back (will be fixed in code) Co-authored-by: Mohammad Mohammad <[email protected]>

The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: Azure#12777 Azure#12555 Azure#13039 Azure#13097 Azure#12822 Azure#13280 Azure#12942 Azure#13248 Azure#13378 This PR is to add those corrections to 2019-11-01 version

Mohammad Mohammad added 2 commits February 18, 2021 11:29

Fix validation errors for UsageDetails_List

822f45e

fix validations for UsageDetails_List invalid format

4d28507

AlahmadiQ8 requested a review from kjeur as a code owner February 18, 2021 16:39

openapi-assignment-bot bot assigned weidongxu-microsoft Feb 18, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Feb 18, 2021

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Feb 18, 2021

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Feb 18, 2021

openapi-workflow-bot bot added the FixS360 label Feb 18, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Python label Feb 18, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Go label Feb 18, 2021

update description for meterId Property inLegacyUsageDetailProperties

7286076

openapi-sdkautomation bot mentioned this pull request Feb 18, 2021

[AutoPR Microsoft.Azure.Management.Consumption] [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 AzureSDKAutomation/azure-sdk-for-net#3253

Closed

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Feb 18, 2021

Mohammad Mohammad added 3 commits February 18, 2021 16:47

add examples for 503 response for Microsoft.Consumption usage details

d3f88ce

fix spelling for productIdentifier description

7f67ae8

fix spell check in productIdentifier description in ModernUsageDetail…

d8d14f5

…Properties

weidongxu-microsoft reviewed Feb 19, 2021

View reviewed changes

AlahmadiQ8 mentioned this pull request Mar 1, 2021

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 #13097

Merged

25 tasks

Lira-tron mentioned this pull request Mar 15, 2021

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-11-01 #13414

Merged

25 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 #13039

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 #13039

AlahmadiQ8 commented Feb 18, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 18, 2021

openapi-pipeline-app bot commented Feb 18, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 18, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 18, 2021

openapi-workflow-bot bot commented Feb 18, 2021

openapi-workflow-bot bot commented Feb 18, 2021

AlahmadiQ8 commented Feb 19, 2021

weidongxu-microsoft Feb 19, 2021

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 #13039

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 #13039

Conversation

AlahmadiQ8 commented Feb 18, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 18, 2021

openapi-pipeline-app bot commented Feb 18, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 18, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Feb 18, 2021

openapi-workflow-bot bot commented Feb 18, 2021

openapi-workflow-bot bot commented Feb 18, 2021

AlahmadiQ8 commented Feb 19, 2021

weidongxu-microsoft Feb 19, 2021

Choose a reason for hiding this comment

AlahmadiQ8 commented Feb 18, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 18, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 18, 2021 •

edited

Loading